fix: Adds url negation regex for course id#36028
Closed
brobro10000 wants to merge 2 commits intomasterfrom
Closed
Conversation
b30df6b to
64e4e40
Compare
64e4e40 to
9c5dd4e
Compare
Merged
2 tasks
Contributor
|
Closing this old abandonned PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This ticket adds a negation endpoints regex to strip from captured
course_ids. Since some URLs being parsed do not contain arun, the existing regex in place captures additional URL strings that are not pertinent to a course_id.This PR adds a negation regex to strip out endpoints that may appear in URLs where a run is not included as part of the course_id. The implementation of including a negation regex as opposed to modifying the original regex was an intentional decision to improve the extensibility of adding additional negation routes if need be.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
https://2u-internal.atlassian.net/browse/ENT-9770
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None"
Other information
Include anything else that will help reviewers and consumers understand the change.